Move JSVGRasterizer unit test to SVG fragment#3347
Merged
HeikoKlare merged 1 commit intoJun 12, 2026
Conversation
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Test Results 188 files 188 suites 26m 49s ⏱️ Results for commit 1c55fb1. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
jsvgrasterizer-test
branch
2 times, most recently
from
8ae5b24 to
75e6393
Compare
HeikoKlare
force-pushed
the
jsvgrasterizer-test
branch
from
75e6393 to
cec86a3
Compare
The JSVGRasterizerTest is currently implemented in the ordinary SWT test bundle, even though the JSVGRasterizer is only one possible (and the current default) SVGRasterizer implementation. The test is actually a unit test for the provider, thus it is properly placed in the SVG fragment that provides the rasterizer implementation itself. This change moves the test class to the SVG fragment and enables it via pure surefire execution. This is similar to what is already done regarding execution of OS-specific unit tests in the OS fragments.
HeikoKlare
force-pushed
the
jsvgrasterizer-test
branch
from
cec86a3 to
1c55fb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSVGRasterizerTest is currently implemented in the ordinary SWT test bundle, even though the JSVGRasterizer is only one possible (and the current default) SVGRasterizer implementation. The test is actually a unit test for the provider, thus it is properly placed in the SVG fragment that provides the rasterizer implementation itself.
This change moves the test class to the SVG fragment and enables it via pure surefire execution. This is similar to what is already done regarding execution of OS-specific unit tests in the OS fragments.